for the record, I can't request a review.

Should we keep the .js file around? And should we update the webpack config to build from the .ts file instead?

what is the use of the webpack file?
I envisioned the js file as a standalone file for people who just want to enable M2 syntax highlighting on their web page.

It generates the minified prism.js that ships with the Style package: https://macaulay2.com/doc/Macaulay2/share/Macaulay2/Style/prism.js

I see. you could use the ts file instead, but I don't think that'd be useful...

Why don't you think it would be useful? I think it would be nice to have just a single source file for the prism grammar that both Macaulay2Web and the Style package can use.

I see. I just meant that there's no obvious benefit to switching to typescript, but yes, it should work equally well.

the import is typescript. imports in typescript vs javascript are confusing because they evolved a lot, with lots of possible syntaxes, but all I can say is this import is needed for typescript to know the variable Prism, otherwise it won't transpile.

Seems a bit strange to have both a .ts file and a .js file for prism, I'd rather just have one, but if we must have two, then they should have the same symbols/variables defined.

import isn't just TypeScript -- it's been supported in JavaScript modules since ES6.

I actually don't see anything TypeScript-specific in the new file -- it's just exactly the .js file with the import statement added and M2SYMBOLS restored. I think we should either add some types and make it TypeScript or just keep it a .js file. And if it is a .ts file, then I agree with Mahrud that we should probably drop the .js file from the repository. Maybe there could be a script in package.json to transpile it to JavaScript, which I suppose we could either commit to git or not. Or maybe we could distribute it via npm.

I agree that import Prism from 'prismjs' is necessary to actually do anything with this file, but I don't think it belongs in the file itself. For consistency with other Prism languages, I think it should just define the language, and a third file would import Prism and the language file:

import Prism from 'prismjs';
import 'path/to/macaulay2.js';
// maybe do some other stuff

I don't think that's how it works in typescript. macaulay2.js (or ts) uses the variable Prism from the module prismjs, so it has to be imported in that file.

I don't think that's how it works in typescript. macaulay2.js (or ts) uses the variable Prism from the module prismjs, so it has to be imported in that file.

I think Doug's point is that the user should have called import Prism before loading macaulay2.ts (or js), which is consistent with other Prism.js languages at least. Does this lead to errors/warnings in typescript? It's been a while since I've used it.

Yeah, you're right, Paul -- it's a TypeScript thing. I removed the import line from prism-M2.ts in the Macaulay2Web repo, ran webpack, and got the following:

ERROR in /home/profzoom/src/macaulay2/Macaulay2Web/src/client/prism-M2.ts
./src/client/prism-M2.ts 7:0-5
[tsl] ERROR in /home/profzoom/src/macaulay2/Macaulay2Web/src/client/prism-M2.ts(7,1)
      TS2304: Cannot find name 'Prism'.

But if I rename prism-M2.ts -> prism-M2.js, webpack runs just fine.

So why not just keep it as a .js file, especially since it doesn't use anything specific to TypeScript? That way, Macaulay2Web, the Style package, and potentially other users that want to use prism for highlighting M2 code could use it.

are you sure this works in ordinary js? in other words, I've no idea how a browser handles an export command in a javascript file that's not called with a module type or imported from another file. These feature have changed too many times for me to follow.

Oh yeah, that's a good point -- export gives an "unexpected token" error in the browser.

Despite the convenience of having them together in the same file, I'm almost wondering if the symbols should go in another file? They're not really related to syntax highlighting with Prism.

yes, let me think about that.

OK. now there is a separate file for the symbols used by Macaulay2Web.